Remove bold spanning header as default. It should be applied to all spanning headers? #134

Melkiades · 2025-11-05T09:51:21Z

What changes are proposed in this pull request?

Removed bold header for tbl_strata.

#133 and #154

Pre-review Checklist (if item does not apply, mark is as complete)

All GitHub Action workflows pass with a ✅
PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
If a bug was fixed, a unit test was added.
Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

If a bug was fixed, a unit test was added.
Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
All GitHub Action workflows pass with a ✅
Approve Pull Request
Merge the PR. Please use "Squash and merge" or "Rebase and merge".

R/theme_gtsummary_roche.R

Melkiades · 2026-01-21T18:20:44Z

@shajoezhu this should be ready to go

github-actions · 2026-01-21T18:27:26Z

Unit Tests Summary

1 files 75 suites 1m 41s ⏱️
75 tests 74 ✅ 1 💤 0 ❌
225 runs 224 ✅ 1 💤 0 ❌

Results for commit d965698.

♻️ This comment has been updated with latest results.

github-actions · 2026-01-21T18:27:30Z

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
tbl_baseline_chg	💚	$41.84$	$-1.01$	tbl_baseline_chg_works
theme_gtsummary_roche	💔	$0.72$	$+1.03$	theme_gtsummary_roche_works
theme_gtsummary_roche	👶		$+0.00$	theme_pre_conversion_modifies_header_not_to_be_bold_and_border_only_0.5

Results for commit c8f0cf0

♻️ This comment has been updated with latest results.

github-actions · 2026-01-21T18:42:25Z

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/add_blank_rows.R                        63       0  100.00%
R/add_difference_row.R                   101       0  100.00%
R/add_hierarchical_count_row.R            33       0  100.00%
R/annotate_gg_km.R                       137       9  93.43%   86-89, 108-112
R/as_ggplot.R                             13      13  0.00%    18-38
R/crane-package.R                          2       2  0.00%    28-29
R/deprecated.R                             6       6  0.00%    15-21
R/forest.R                                68      68  0.00%    35-178
R/get_cox_pairwise_df.R                   50      13  74.00%   68-71, 74-77, 82, 92-95
R/gg_km_utils.R                          102      16  84.31%   94, 134-151, 167
R/gg_km.R                                143      37  74.13%   54-57, 74, 101, 175-180, 183-186, 196-198, 203-204, 238-240, 247-250, 254, 265-269, 282, 284-286
R/label_roche.R                           72       0  100.00%
R/modify_header_rm_md.R                   18       2  88.89%   35-36
R/modify_zero_recode.R                    13       0  100.00%
R/tbl_baseline_chg.R                     212       0  100.00%
R/tbl_hierarchical_rate_and_count.R      148       0  100.00%
R/tbl_hierarchical_rate_by_grade.R       271       3  98.89%   162-164
R/tbl_listing.R                           35       0  100.00%
R/tbl_null_report.R                        9       0  100.00%
R/tbl_roche_subgroups.R                  119     119  0.00%    34-168
R/tbl_roche_summary.R                     64       0  100.00%
R/tbl_shift.R                            116       0  100.00%
R/tbl_survfit_quantiles.R                132       1  99.24%   295
R/tbl_survfit_times.R                     92       0  100.00%
R/theme_gtsummary_roche.R                 78       0  100.00%
R/utils.R                                 36       0  100.00%
TOTAL                                   2133     289  86.45%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/theme_gtsummary_roche.R       +4       0  +100.00%
TOTAL                           +4       0  +0.03%

Results for commit: d965698

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Signed-off-by: Davide Garolini <dgarolini@gmail.com>

Melkiades · 2026-01-22T14:54:03Z

@shajoezhu ready to go!

shajoezhu · 2026-01-23T14:08:51Z

hi @Melkiades , can you fix the failed test. thanks

Melkiades · 2026-01-23T14:32:51Z

I do not know this failure what it means... Maybe we can ask Franciszek?

 ✖ Failed to download uuid 1.2-1 (aarch64-apple-darwin20)
  ✔ Installed data.table 1.18.0  (97ms)
  ✔ Installed gt 1.3.0  (37ms)
  Error: 
  ! error in pak subprocess
  Caused by error in `file(con, "rb")`:
  ! cannot open the connection
  ---
  Backtrace:
  1. pak::lockfile_install(".github/pkg.lock")
  2. pak:::remote(function(...) { …
  3. err$throw(res$error)
  ---
  Subprocess backtrace:
   1. base::withCallingHandlers(cli_message = function(msg) { …
   2. get("lockfile_install_internal", asNamespace("pak"))(...)
   3. plan$install()
   4. pkgdepends::install_package_plan(plan, lib = private$library, num_workers = nw, …
   5. base::withCallingHandlers({ …
   6. pkgdepends:::start_task(state, task)
   7. pkgdepends:::start_task_install(state, task)
   8. pkgdepends:::make_install_process(filename, lib = lib, metadata = metadata)
   9. pkgdepends:::detect_package_archive_type(filename)
  10. base::readBin(file, what = "raw", n = 6)
  11. base::file(con, "rb")
  12. base::.handleSimpleError(function (e) …
  13. global h(simpleError(msg, call))
  Execution halted
  Error: Process completed with exit code 1.

github-actions · 2026-01-27T08:39:50Z

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

walkowif · 2026-01-27T08:47:48Z

I have read the CLA Document and I hereby sign the CLA

walkowif · 2026-01-27T09:15:41Z

@Melkiades I cleared the GitHub runner caches and reran the workflows for this PR. Seems like the macOS workflow problem was caused by some old cached packages. However, now we have a seemingly unrelated test failure in ubuntu-latest (oldrel-1) workflow.

shajoezhu

lgtm. thanks man! unblock merging

fix

3b17bbc

Melkiades commented Nov 5, 2025

View reviewed changes

R/theme_gtsummary_roche.R Outdated Show resolved Hide resolved

shajoezhu and others added 3 commits November 28, 2025 13:25

Merge branch 'main' into 133_no_bold_spanning_header@main

65ae550

Merge branch 'main' into 133_no_bold_spanning_header@main

db3e7f4

Following Daniel suggestion

2388a0d

Melkiades requested a review from shajoezhu January 21, 2026 18:20

fix tests

6a39077

shajoezhu and others added 2 commits January 22, 2026 09:54

Merge branch 'main' into 133_no_bold_spanning_header@main

14f4599

Merge branch 'main' into 133_no_bold_spanning_header@main

0a75440

Signed-off-by: Davide Garolini <dgarolini@gmail.com>

Melkiades added 2 commits January 22, 2026 16:15

fix also line sizes

8d4b320

fix border issue too

53882e3

This was linked to issues Jan 22, 2026

Update theme to not bold spanning headers #133

Closed

{flextable} border for spanning header a bit thicker than the other borders #154

Closed

fix NEWS

659479f

fix tests

8fbd591

Melkiades enabled auto-merge (squash) January 23, 2026 14:22

chore: run pipeline

d965698

fix?

6aff68a

shajoezhu approved these changes Feb 2, 2026

View reviewed changes

Melkiades merged commit cd0c3be into main Feb 2, 2026
23 of 26 checks passed

Melkiades deleted the 133_no_bold_spanning_header@main branch February 2, 2026 15:00

github-actions bot locked and limited conversation to collaborators Feb 2, 2026

Uh oh!

Remove bold spanning header as default. It should be applied to all spanning headers? #134

Remove bold spanning header as default. It should be applied to all spanning headers? #134

Uh oh!

Conversation

Melkiades commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Melkiades commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests Summary

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Performance Difference

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Diff against main

Uh oh!

Melkiades commented Jan 22, 2026

Uh oh!

shajoezhu commented Jan 23, 2026

Uh oh!

Melkiades commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

walkowif commented Jan 27, 2026

Uh oh!

walkowif commented Jan 27, 2026

Uh oh!

shajoezhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Melkiades commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 27, 2026 •

edited

Loading